search

buildo / react-components

Collection of general React components used in buildo projects.
http://react-components.buildo.io/
MIT License
157 stars 21 forks source link

#1139: [Typo] TextOverflow popover.event type (closes #1139) #1147

Closed FrancescoCioria closed 7 years ago

FrancescoCioria commented 7 years ago

Closes #1139

Test Plan

tests performed

tested inside VSCode:

// OK
const x: TooltipRequiredProps = {
  children: '' as React.ReactNode,
  popover: {
    content: ''
  }
};

// ERROR for `event`
const x: TooltipRequiredProps = {
  children: '' as React.ReactNode,
  popover: {
    content: '',
    event: 'hover'
  }
};

cross browser compatibility

Should be compatible with every browser below. Check the ones you tested!

tests not performed (domain coverage)

At times not everything can be tested, and writing what hasn't been tested is just as important as writing what has been tested.

An example of partial test is a field displaying 4 possible values. If 3 values are tested, with screenshots, and 1 is not, then it should be mentioned here.

FrancescoCioria commented 7 years ago

ups, this is a duplicate of #1140 (even if the implementation is slightly different)