Update react-select to version 1 (closes #1158)

buildo / react-components

Collection of general React components used in buildo projects.

http://react-components.buildo.io/

MIT License

157 stars 21 forks source link

Update react-select to version 1 (closes #1158) #1157

Closed giogonzo closed 6 years ago

giogonzo commented 6 years ago

tests performed

[x] tests are passing after updating two snapshots: one was due to an aria-attribute which we don't care about at the moment, the other is a 2px becoming a 5px (see screenshot)
[x] render dropdown and timepicker in the current kitchen sink: there's a single small glitch (see screenshot, couldn't track it down - maybe worth opening a separate issue?)
[ ] test on a real react 16 project

ecamellini commented 6 years ago

@FrancescoCioria @giogonzo since you are already on this, you could also add the name param to the Dropdown API, which should just be passed to the Select as it is

nemobot commented 6 years ago

giogonzo commented 6 years ago

@ecamellini opened #1160 for your request and #1159 for the other outstanding styling issue