#1211: Tablo Column does not accept sortable prop (closes #1211)

buildo / react-components

Collection of general React components used in buildo projects.

http://react-components.buildo.io/

MIT License

157 stars 21 forks source link

#1211: Tablo Column does not accept sortable prop (closes #1211) #1247

Closed ecamellini closed 6 years ago

ecamellini commented 6 years ago

Closes #1211

Test Plan

tests performed

None.

ecamellini commented 6 years ago

@veej I'm not sure about this. What I see is that sortable works in the showroom examples, meaning that the fact that TS complains is probably only due to an error in the type interfaces that this PR should fix. Do you think this is sufficient?

ecamellini commented 6 years ago

@veej I don't know if TS complains or not 😅I don't know how to test it. Should we maybe put it in both props (intrinsic and not)?

veej commented 6 years ago

If tsc doesn't complain during the build of react-components itself, I think it's 👍

nemobot commented 6 years ago