search

buildo / react-components

Collection of general React components used in buildo projects.
http://react-components.buildo.io/
MIT License
157 stars 21 forks source link

#1253: Deprecate Icon component in favor of SVG icons (closes #1253) #1254

Closed veej closed 6 years ago

veej commented 6 years ago

Closes #1253

Test Plan

tests performed

A Test Plan is used to show what you tested to make sure your code works fine. You should write here all that you did to test, and provide some results of your testing.

These results can be screenshots, query results, or even just pointers to unit tests that successfully passed.

tests not performed (domain coverage)

At times not everything can be tested, and writing what hasn't been tested is just as important as writing what has been tested.

An example of partial test is a field displaying 4 possible values. If 3 values are tested, with screenshots, and 1 is not, then it should be mentioned here.

FrancescoCioria commented 6 years ago

@veej a general comment (I'll make a better review later on): I think you should use t.ReactChild (I'm not sure, just check) instead of t.ReactChildren in order to be consistent with TS typings and refuse JSX.Element[]

nemobot commented 6 years ago