buildo / react-components

Collection of general React components used in buildo projects.
http://react-components.buildo.io/
MIT License
157 stars 21 forks source link

#1265: FormField is required acts weird on custom label (closes #1265) #1270

Closed veej closed 6 years ago

veej commented 6 years ago

Closes #1265

Test Plan

tests performed

<FormField        
        label={
          <FlexView
            vAlignContent="top"
            hAlignContent="right"
            width="150px"
          >
            <FormattedMessage id={//some message code here} />
          </FlexView>
        }
        className="form-details-row"
        required={this.props.required}
      >
        <FlexView shrink className="row-content">
           <input type='text' />
        </FlexView>
      </FormField>

I can see only one ::before in dev tools (and only one "required" asterisk)

veej commented 6 years ago

@gio please review only the last commit

nemobot commented 6 years ago