search

buildo / react-components

Collection of general React components used in buildo projects.
http://react-components.buildo.io/
MIT License
157 stars 21 forks source link

#1285: Upgrade react-select to 2.x (closes #1285) #1303

Closed fes300 closed 5 years ago

fes300 commented 5 years ago

Closes #1285

Test Plan

tests performed

A Test Plan is used to show what you tested to make sure your code works fine. You should write here all that you did to test, and provide some results of your testing.

These results can be screenshots, query results, or even just pointers to unit tests that successfully passed.

tests not performed (domain coverage)

At times not everything can be tested, and writing what hasn't been tested is just as important as writing what has been tested.

An example of partial test is a field displaying 4 possible values. If 3 values are tested, with screenshots, and 1 is not, then it should be mentioned here.

veej commented 5 years ago

In the meanwhile I made the issue breaking since we're changing all the interface for the component

veej commented 5 years ago

There are also issue with the style (e.g. isDisabled doesn't change the style at all and the menu has an horizontal scrollbar)

nemobot commented 5 years ago