Adding preview to CI - Githubissues

buildo / react-components

Collection of general React components used in buildo projects.

http://react-components.buildo.io/

MIT License

157 stars 21 forks source link

Adding preview to CI #1312

Closed ecamellini closed 5 years ago

ecamellini commented 5 years ago

Pre-requisites:

[x] merging https://github.com/buildo/terraform/pull/236
[x] applying terraform changes
[x] deploying new github-workflow-pal from master (not really required for the merge --> just check http://react-components.preview.our.buildo.io/adding-preview.html)
[x] testing preview on this PR (pipeline already applied)

ecamellini commented 5 years ago

It doesn't work, but it should 🤷‍♂️

ecamellini commented 5 years ago

Found the problem, let's see

ecamellini commented 5 years ago

http://react-components.preview.our.buildo.io/adding-preview.html it works! But...since this build does not produce a bundle with a different hash every time => all files are overwritten. This means that only the latest build will be shown in preview, and can be misleading.

Maybe it's not a problem? There are not many PRs in parallel on BRC.

See: http://react-components.preview.our.buildo.io/adding-preview.html

ecamellini commented 5 years ago

@gabro now it works: I managed to produce a bundle and I'm uploading to the bucket only index file and bundle files:

content of the build folder:

nemobot commented 5 years ago