buildo / react-components

Collection of general React components used in buildo projects.
http://react-components.buildo.io/
MIT License
157 stars 21 forks source link

Dropdown heights are inconsistent with CSS parameter #1334

Closed ecamellini closed 5 years ago

ecamellini commented 5 years ago

I set $height: 42px; before @import '~buildo-react-components/src/Dropdown/dropdown.scss';.

The variable effect is visible: if I change it, the height of dropdowns around the app changes.

However:

The actual height of dropdowns seems to be 2px less than the value I set:

image

When using FormField and mixing dropdown with other inputs, it seems to be out of alignment even though I don't set margins/paddings:

image

multi dropdowns seem to be 2px more than the value I set:

image

ecamellini commented 5 years ago

Closed by #1336