buildo / react-components

Collection of general React components used in buildo projects.
http://react-components.buildo.io/
MIT License
157 stars 21 forks source link

Bump mixin-deep from 1.3.1 to 1.3.2 #1367

Closed dependabot[bot] closed 5 years ago

dependabot[bot] commented 5 years ago

Bumps mixin-deep from 1.3.1 to 1.3.2.

Commits - [`754f0c2`](https://github.com/jonschlinkert/mixin-deep/commit/754f0c20e1bc13ea5a21a64fbc7d6ba5f7b359b9) 1.3.2 - [`90ee1fa`](https://github.com/jonschlinkert/mixin-deep/commit/90ee1fab375fccfd9b926df718243339b4976d50) ensure keys are valid when mixing in values - See full diff in [compare view](https://github.com/jonschlinkert/mixin-deep/compare/1.3.1...1.3.2)
Maintainer changes This version was pushed to npm by [doowb](https://www.npmjs.com/~doowb), a new releaser for mixin-deep since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/buildo/react-components/network/alerts).
nemobot commented 5 years ago

iagobruno commented 5 years ago

image

araujoetal commented 5 years ago

👀

Beyarz commented 5 years ago

👁️👁️

ahungry commented 5 years ago

The package going from 1.3.1 to 1.3.2 alters behavior and changes the output of this test from passing to failing:

           it('should do a deep merge', function () {
             var obj1 = { a: { prototype: { a: 1 }, b: 1, c: 1, d: { e: 1, f: 1 } } };
             var obj2 = { a: { prototype: { b: 1 }, b: 2, d: { f: 'f' } } };

             mixinDeep(obj1, obj2).should.eql({ a: { prototype: { a: 1, b: 1 }, b: 2, c: 1, d: { e: 1, f: 'f' } } });
           });

I don't think package dependencies should auto-upgrade when the dependency can't be relied on to follow semver correctly.

gabro commented 5 years ago

@ahungry fair point, although that’s why we have tests. If our tests can’t observe any visible changes, then we’re fine with bumping the dep

ademidun commented 5 years ago

For context: @gabro's tweet explains this PR very well:

https://twitter.com/gabro27/status/1173547934132178944

Made me eat my words 😂 https://twitter.com/tomiwa1a/status/1174678002845794304

2gnpvc

ghost commented 5 years ago

beep

nawaphonOHM commented 5 years ago

Hello world

mwenghi commented 5 years ago

@dependabot cancel merge

dependabot[bot] commented 5 years ago

Sorry, only users with push access can use that command.

mwenghi commented 5 years ago

@dependabot reopen

dependabot[bot] commented 5 years ago

Sorry, only users with push access can use that command.

stefanomezza commented 5 years ago

@dependabot this sentence is false

bhatvikrant commented 5 years ago

image

yogo1212 commented 5 years ago

if you ignore the entertainment value, this PR is very carbon ineffective. turn off the bot, don't automate pollution - i say