search

buildo / react-components

Collection of general React components used in buildo projects.
http://react-components.buildo.io/
MIT License
157 stars 21 forks source link

proposal: remove "success" and "error" Button statuses #1377

Open giogonzo opened 5 years ago

giogonzo commented 5 years ago

As per recent changes to the guidelines, we never use display feedback on the action performed directly inside the button UI (we typically display it alongside the submit area using different types of error UI)

For this reason, showing feedback should not be handled by this component anymore (while the "loading" state should remain)

giogonzo commented 5 years ago

Discussed offline with the rest of the team, the perception is that it would be too speculative as a change right now. Also, we might want to remove the "error" case only and keep the "success" one instead.