#1386: Add "empty states" component (closes #1386)

buildo / react-components

Collection of general React components used in buildo projects.

http://react-components.buildo.io/

MIT License

157 stars 21 forks source link

#1386: Add "empty states" component (closes #1386) #1389

Closed ecamellini closed 4 years ago

ecamellini commented 4 years ago

Closes [#2520970](https://buildo.kaiten.io/space/[object Object]/card/2520970)

⚠️ The line above was added during the automatic migration of all github project issues to Kaiten. The old GH issue link is kept here for reference (it is now deprecated, continue follow the original issue on Kaiten).

Closes #1386

Test Plan

ecamellini commented 4 years ago

@giogonzo @alessandravilla should I also add the guidelines README? English or Italian? Also, what should I do with the paper document after we merge this?

https://paper.dropbox.com/doc/Empty-states--AoYE40Ps4f937XUou_KXkcmvAg-ks6uBIJYVm4ZaKPNmRCE5

ecamellini commented 4 years ago

Perfect, allora traduco, metto qua nel README, e depreco il paper direi.

alessandravilla commented 4 years ago

Non riesco a fare preview pr, guardando l'immagine che hai caricato direi di:

cambiare font weight del title in bold
mettere il primary style al btn
aumentare un po' i padding tra i componenti

ecamellini commented 4 years ago

@giogonzo @alessandravilla addressed comments and added README, in English. It should be ready to be merged 🎉

nemobot commented 4 years ago