search

buildo / react-components

Collection of general React components used in buildo projects.
http://react-components.buildo.io/
MIT License
157 stars 21 forks source link

#1439: fix overall inconsistency of examples (closes #1439) #1440

Closed marcopiii closed 4 years ago

marcopiii commented 4 years ago

Closes #2520585

⚠️ The line above was added during the automatic migration of all github project issues to Kaiten. The old GH issue link is kept here for reference (it is now deprecated, continue follow the original issue on Kaiten).

Closes #1439

I changed the name of .prettierrc.yml since it was missing the initial . so it was not actually being used, then i ran yarn prettier-fix to apply the formatting rules to the whole project.

kanbanbot commented 4 years ago

giogonzo commented 4 years ago

@aSlug I verified it: if I pull master and edit an Example file, "save without format", then run prettier-fix -> nothing happens (and prettier-check does not complain). I think it's sufficient to adapt the package scripts to also consider .md files in order to enforce this CI-side

marcopiii commented 4 years ago

Yes I just realized that I manually ran it on every example.md file, intentionally avoiding README.md files, and after that i ran yarn prettier-fix

resolving with https://github.com/buildo/react-components/pull/1443