search

buildo / react-components

Collection of general React components used in buildo projects.
http://react-components.buildo.io/
MIT License
157 stars 21 forks source link

Panel: panel-content should be shrinkable #362

Closed nerder closed 8 years ago

nerder commented 8 years ago

description

Panel have a shrink rule that is opinionated and do not allow the user to customize the behaviour of panel-content this will end in some tricky workaround to avoid this. IMO is way better to fix this by our side and let the devs free to customize panel-contentas they want.

how to reproduce

This is the involved line of code :

<FlexView className='panel-content' column grow shrink={false} style={{ position: 'relative' }}>

specs

This is the proposed solution:

<FlexView className='panel-content' column grow style={{ position: 'relative' }}>

misc

About the solution proposed, leave the shrink as true (flex: 1 1 auto) will not change the behaviour in any ways, and the same result can always be reached adding a child FlexView with a shrink: false property, in the opposite way instead is very opinionated, and if we want for instance make the content scroll we have to do something like a small workaround (as proposed here for instance)

gabro commented 8 years ago

@FrancescoCioria is this still a concern?

FrancescoCioria commented 8 years ago

no, duplicate of #414