buildo / react-cookie-banner

React Cookie banner which can be automatically dismissed with a scroll. Because fuck The Cookie Law, that's why.
http://react-components.buildo.io/#cookiebanner
MIT License
182 stars 19 forks source link

#23: Cookie expiration date (closes #23) #24

Closed FrancescoCioria closed 8 years ago

FrancescoCioria commented 8 years ago

Issue #23

Test Plan

tests performed

At times not everything can be tested, and writing what hasn't been tested is just as important as writing what has been tested.

An example of partial test is a field displaying 4 possible values. If 3 values are tested, with screenshots, and 1 is not, then it should be mentioned here.}

gabro commented 8 years ago

How about adding a unit test? The logic seems "complex" enough to deserve one

gabro commented 8 years ago

You have basically already written it in the test plan ;-)

nemobot commented 8 years ago