#29: Template and cookie logic should live in different components (closes #29) - Githubissues

buildo / react-cookie-banner

React Cookie banner which can be automatically dismissed with a scroll. Because fuck The Cookie Law, that's why.

http://react-components.buildo.io/#cookiebanner

MIT License

182 stars 19 forks source link

#29: Template and cookie logic should live in different components (closes #29) #30

Closed FrancescoCioria closed 7 years ago

FrancescoCioria commented 7 years ago

Issue #29

Test Plan

tests performed

change example and pass custom function children where BannerContent is wrapped by a div with onClick={onAccept}
click anywhere in the banner
- cookies accepted
- banner disappears

tests not performed (domain coverage)

At times not everything can be tested, and writing what hasn't been tested is just as important as writing what has been tested.

An example of partial test is a field displaying 4 possible values. If 3 values are tested, with screenshots, and 1 is not, then it should be mentioned here.}

nemobot commented 7 years ago