#31: React15 throws warning for unknown prop (closes #31)

buildo / react-cookie-banner

React Cookie banner which can be automatically dismissed with a scroll. Because fuck The Cookie Law, that's why.

http://react-components.buildo.io/#cookiebanner

MIT License

182 stars 19 forks source link

#31: React15 throws warning for unknown prop (closes #31) #32

Closed FrancescoCioria closed 7 years ago

FrancescoCioria commented 7 years ago

Issue #31

Test Plan

tests performed

In the example:

before we had this
now it's gone 💪

tests not performed (domain coverage)

At times not everything can be tested, and writing what hasn't been tested is just as important as writing what has been tested.

An example of partial test is a field displaying 4 possible values. If 3 values are tested, with screenshots, and 1 is not, then it should be mentioned here.}

FrancescoCioria commented 7 years ago

Yap, React 15 is breaking the tests. When it's fixed I'll reassign it to you. Thanks!

FrancescoCioria commented 7 years ago

naaa too hard, I'll revert to React@0.13 and fix it in another issue :)

nemobot commented 7 years ago