search

buildo / react-cookie-banner

React Cookie banner which can be automatically dismissed with a scroll. Because fuck The Cookie Law, that's why.
http://react-components.buildo.io/#cookiebanner
MIT License
182 stars 19 forks source link

Add a 'cookiePath' property #34

Closed ghostd closed 7 years ago

ghostd commented 7 years ago

Here is a proposal to add a new "cookiePath" property.

This new property would fix a weird bug on IE: on my SPA (which uses react-router with history API), when the user clicks on the banner to close it, then navigate to another page, sometimes the cookie vanish and the banner is displayed again.

I think the bug is related to this: http://stackoverflow.com/questions/8292449/internet-explorer-sends-the-wrong-cookie-when-the-paths-overlap#8314164

If i force the cookie path to '/', i dont have the bug (and browser-cookie-lite does not force it). So this property let me set the path i wish.

I did not set a default value to not break the current behavior.

gabro commented 7 years ago

Thanks for this PR! It seems like a reasonable addition and the code looks 👍 I'll leave the final word to @FrancescoCioria

nemobot commented 7 years ago