search

buildo / react-cookie-banner

React Cookie banner which can be automatically dismissed with a scroll. Because fuck The Cookie Law, that's why.
http://react-components.buildo.io/#cookiebanner
MIT License
182 stars 19 forks source link

Server side rendering issues #41

Closed adomrockie closed 6 years ago

adomrockie commented 6 years ago

Hi guys, can we merge the waiting pull request to use react-cookies with SSR?

Currently having invalid checksum issues with server side rendering.

FrancescoCioria commented 6 years ago

Hi @adomrockie , unfortunately that PR is no longer mergeable (nor it was before as it made too many unwanted changes).

However we can work on a new solution :)

It may enough replacing cookie-lite with react-cookie as suggested in that PR

adomrockie commented 6 years ago

Thanks, that will be great. Is this something you looking to do soon? or should we do it ourselves.

FrancescoCioria commented 6 years ago

I already started looking into it and was planning to open a PR within the following week, but of course PRs are welcome if you need it sooner :)

FrancescoCioria commented 6 years ago

nevermind, I already opened the PR 😬 you can check the code in #42 , what do you think? (I'm new to SSR so I might have done some stupid mistakes)