search

buildo / react-cookie-banner

React Cookie banner which can be automatically dismissed with a scroll. Because fuck The Cookie Law, that's why.
http://react-components.buildo.io/#cookiebanner
MIT License
182 stars 19 forks source link

Use official typings for `react-cookie` #46

Open FrancescoCioria opened 6 years ago

FrancescoCioria commented 6 years ago

requirements

react-cookie is about to add official typings to their lib: https://github.com/reactivestack/cookies/pull/124.

As soon as they merge and publish them, we should remove our react-cookie.d.ts in favour of them

specs

remove react-cookie.d.ts and update react-cookie to the version with TS typings

misc

{optional: other useful info}

FrancescoCioria commented 6 years ago

Update: the typings are merged in reactivestack, but without this PR https://github.com/reactivestack/cookies/pull/144 they are useless

ikappas commented 6 years ago

@FrancescoCioria reactivestack/cookies#144 seems to be fixed. Any update on this?