search

buildo / react-cookie-banner

React Cookie banner which can be automatically dismissed with a scroll. Because fuck The Cookie Law, that's why.
http://react-components.buildo.io/#cookiebanner
MIT License
182 stars 19 forks source link

Documentation of link prop is obsolete #56

Closed CorwinCZ closed 6 years ago

CorwinCZ commented 6 years ago

Current documentation of link prop found here is out-dated. Current implementation required JSX element instead of object - as found here

Documentation can be updated this way (line 11):

| **link** | ```<a href="http://demo.url" target="_blank">Link text</a>``` |  | *optional*. JSX element to link to your cookie-policy page |

Originaly I wanted to create PR for this issue, but it is not possible to push new branch to repository.

gabro commented 6 years ago

@CorwinCZ thanks for reporting the issue :)

You can't push a branch to this repository, but you can fork it, push the fix on your fork and submit a PR from there, as explained in https://help.github.com/articles/creating-a-pull-request-from-a-fork/

Thanks!