search

buildo / react-cookie-banner

React Cookie banner which can be automatically dismissed with a scroll. Because fuck The Cookie Law, that's why.
http://react-components.buildo.io/#cookiebanner
MIT License
182 stars 19 forks source link

Incorrect peer dependency. #59

Open Huespal opened 5 years ago

Huespal commented 5 years ago

Hello

Yarn complains about this dependency lib: react-addons-clone-with-props.

warning "react-cookie-banner > react-addons-clone-with-props@0.14.8" has incorrect peer dependency "react@^0.14.8".

Can be updated? I'm using react 16.5.1.

Thanks.

TkDodo commented 5 years ago

Well this component is not really react-16 ready, as it still uses the deprecated componentWillReceiveProps lifecycle method. It works with react-16, but in strict mode, I get the following warning:

componentWillReceiveProps: Please update the following components to use static getDerivedStateFromProps instead: CookieBanner

are there any plans on updating the component? Thanks!