buildo / react-placeholder

A React component to easily replicate your page with nice placeholders while the content is loading
MIT License
1.61k stars 96 forks source link

Incompatible with tailwind #127

Open FranciscoKloganB opened 1 year ago

FranciscoKloganB commented 1 year ago

Recently detected that it is not possible to define width and height using tailwind directives because defaultStyles, is applied on rect.

const RectShape: React.FC<Props> = ({ className, style, color }) => {
  const defaultStyle = {
    backgroundColor: color,
    width: '100%',
    height: '100%',
    marginRight: 10
  };

  return (
    <div
      className={joinClassNames('rect-shape', className)}
      style={{ ...defaultStyle, ...style }}
    />
  );
};

Would you mind modifying the API to support these use cases or would you be open to a PR without breaking changes, which allowed both behaviours?

BrianMitchL commented 1 year ago

I'd be happy to look at a PR if you'd like to add the use case without breaking changes.