buildpacks-community / kpack-cli

A command line interface for interacting with kpack.
Other
33 stars 15 forks source link

`kp secret create --registry` does not correctly parse registries #324

Closed fcaroline2020 closed 1 year ago

fcaroline2020 commented 1 year ago

Summary

When using kp secret create --registry https://index.docker.io/v1/ the secret is erroneously created.

Expected Secret Data

{"auths":{"https://index.docker.io/v1/":{"username":"....

Actual Secret Data

{"auths":{"https:":{"username":"....

Workaround

In the meantime use flags --dockerhub and --gcr instead as these are correctly generating secrets

Solution

Remove logic that tries to parse the registry host if the user passes in the whole path to the repo