search

buildpacks / imgutil

Helpful utilities for working with images
Apache License 2.0
23 stars 41 forks source link

Use the Image Digest to save it in a Registry #251

Closed jjbustamante closed 2 months ago

jjbustamante commented 5 months ago

This change was done to replace the image name with the digest when saving it in a registry, the idea is to use it when we are creating multi-arch images and we need to save each intermediate image before creating the Image Index.

The work is based on Husni's PR, because I need his logic to create the Image Index but my change is actually only in this commit

This is a DRAFT! I am not sure if this is the best way to do it, I just needed a way to solve my problem and develop the PoC

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 21.83623% with 315 lines in your changes are missing coverage. Please review.

Project coverage is 55.75%. Comparing base (7ebe5c6) to head (64e6aff). Report is 22 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/buildpacks/imgutil/pull/251/graphs/tree.svg?width=650&height=150&src=pr&token=145I8KQAU5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=buildpacks)](https://app.codecov.io/gh/buildpacks/imgutil/pull/251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=buildpacks) ```diff @@ Coverage Diff @@ ## main #251 +/- ## ========================================== - Coverage 58.29% 55.75% -2.53% ========================================== Files 32 38 +6 Lines 3694 3778 +84 ========================================== - Hits 2153 2106 -47 - Misses 1184 1349 +165 + Partials 357 323 -34 ```
jjbustamante commented 2 months ago

We don't need this change anymore, I updated our pack manifest commands PR to use the latest version of the imgutil code (after we merged the image index logic) and we don't need this hack.