search

buildpacks / imgutil

Helpful utilities for working with images
Apache License 2.0
23 stars 41 forks source link

Fix: `archive/tar: write too long` error when using Docker Desktop containerd backend #275

Closed natalieparellano closed 1 month ago

natalieparellano commented 1 month ago

Fixes (in part) https://github.com/buildpacks/pack/issues/2174

This is somewhat of a band-aid solution and degrades performance because we have to read the uncompressed layer bits to get the uncompressed layer size for layers that we docker save out of the daemon (re-used layers and all the base layers).

The better longer-term fix will be to send OCI-layout formatted tars when we have all the layers available (when using containerd as the backing store, this will always be true).

natalieparellano commented 1 month ago

do we need docker 25 in the runner to be able to test it?

Yeah, we need it. And, containerd should be enabled as the backing storage. It's a bit of a mess.