Setting `SERVICE_BINDING_ROOT` does not apply at detect

buildpacks / libcnb

A non-opinionated language binding for the Cloud Native Buildpack Buildpack and Extension specifications

Apache License 2.0

31 stars 13 forks source link

Setting `SERVICE_BINDING_ROOT` does not apply at detect #105

Closed dmikusa closed 2 years ago

dmikusa commented 2 years ago

If you set an alternative location for SERVICE_BINDING_ROOT this only presently applies at build time. At detect, the standard /platform/bindings is always used.

Detect calls NewBindingsFromPath which is given /platform/bindings. This method does not look at EnvServiceBindings, so it doesn't honor this env variable.

samj1912 commented 2 years ago

@dmikusa-pivotal thanks for the report! Will roll out a fix shortly