search

buildpacks / libcnb

A non-opinionated language binding for the Cloud Native Buildpack Buildpack and Extension specifications
Apache License 2.0
31 stars 13 forks source link

Finish removing shell-specific logic (RFC #0093) #148

Closed dmikusa closed 1 year ago

dmikusa commented 2 years ago

This PR submits the second half of RFC #0093, which is removing the Direct field from the Process struct and also switching the Command field from a string to a list of strings.

This is a breaking change as it removes a field from the struct and changes an existing field, but given this change is only going into v2+ that seems to be the correct path.

Resolves #70.

Signed-off-by: Daniel Mikusa dmikusa@vmware.com

samj1912 commented 2 years ago

@dmikusa-pivotal we should probably block this PR on the lifecycle release which removes shell support and adds support for buildpack api 0.9

dmikusa commented 2 years ago

Oh, ok. I thought that had happened already. Do you know the timing of that release? I agree we should wait, but that's going to block us from being able to cut a 2.0 release. There are definitely breaking changes required here.

Maybe we could do a milestone release in the meantime? Does Go have a mechanism for that? Or would one typically just use a specific release commit hash? Just trying to think of a way we can have something that's semi-finished for folks to start playing with, I know I would like to try getting libpakv2 ready to go soon.

samj1912 commented 2 years ago

I don't think we need to block 2.0 on this issue. I'm happy to cut a release with just BP API 0.8. We still need to clean up some other things though.

samj1912 commented 2 years ago

Marking this as draft so that it is not accidentally merged till the lifecycle release.

natalieparellano commented 1 year ago

Now that lifecycle 0.15.0 is out with Buildpack API 0.9 support, could this be un-drafted?

dmikusa commented 1 year ago

OK, all the tests pass and I merged this in. @samj1912 Should we cut a release?