search

buildpacks / libcnb

A non-opinionated language binding for the Cloud Native Buildpack Buildpack and Extension specifications
Apache License 2.0
32 stars 13 forks source link

Convert nested binding credentials to JSON #256

Closed modulo11 closed 9 months ago

modulo11 commented 10 months ago

Fixes https://github.com/buildpacks/libcnb/issues/254.

Fix swallowing the parsing error and marshal properties to JSON if they are not a string.

c0d1ngm0nk3y commented 9 months ago

@dmikusa @samj1912 Any thoughts on this pr?

dmikusa commented 9 months ago

Looks good to me, just the one suggestion with the test.