search

buildpacks / libcnb

A non-opinionated language binding for the Cloud Native Buildpack Buildpack and Extension specifications
Apache License 2.0
31 stars 13 forks source link

align toml tag of `working-dir` with spec #268

Closed phil9909 closed 11 months ago

phil9909 commented 12 months ago

See https://github.com/buildpacks/spec/blob/buildpack/v0.10/buildpack.md#launchtoml-toml

See also: same PR but for 2.x release #269

c0d1ngm0nk3y commented 11 months ago

@dmikusa Maybe you can have a look. This is really small and clearly a bug imho since it contradicts the spec.

dmikusa commented 11 months ago

No questions about the actual change, but I need to double-check this with someone on the Buildpacks team.

The RFC calls for working-directory. https://github.com/buildpacks/rfcs/blob/main/text/0081-process-specific-working-directory.md#how-it-works

I see it was clearly changed, but it's unclear why it was changed, just that it was changed, https://github.com/buildpacks/spec/commit/e3ba9c3b7a5c702a68c8df4a7b5e9ab373e8cf9c. If you know more, please share.

I'd like to know more cause I'm concerned with potential breaking changes.

Conversation on Buildpacks Slack, if you'd like to follow, https://cloud-native.slack.com/archives/C0331B5QS02/p1701056869228749.