search

buildpacks / libcnb

A non-opinionated language binding for the Cloud Native Buildpack Buildpack and Extension specifications
Apache License 2.0
31 stars 13 forks source link

Add a makefile to the repository to run linting and tests #63

Closed sambhav closed 3 years ago

sambhav commented 3 years ago

Fixes #61

dmikusa commented 3 years ago

@samj1912 Out of curiosity, why did all of the file permissions change in the tests? Is that an artifact of running with make? Not that it seems like a problem to change them, it just makes this PR a lot larger.

sambhav commented 3 years ago

@samj1912 Out of curiosity, why did all of the file permissions change in the tests? Is that an artifact of running with make? Not that it seems like a problem to change them, it just makes this PR a lot larger.

That was due to the lint configuration (gosec). I separated those changes from the makefile changes in different commits.

https://github.com/buildpacks/libcnb/pull/63/commits/ccab05cded7c6636d52bd6d7b702705de65ede8e for lint fixes.

sambhav commented 3 years ago

@ekcasey I don't have merge permissions.