search

buildpacks / lifecycle

Reference implementation of the Cloud Native Buildpacks lifecycle
https://buildpacks.io
Apache License 2.0
185 stars 103 forks source link

Fix auth by wrapping keychain in a ResolvedKeychain #1334

Closed natalieparellano closed 2 months ago

natalieparellano commented 2 months ago

Prior to https://github.com/buildpacks/lifecycle/pull/1315, all keychains passed to NewMultiKeychain were resolved keychains, which prevented the credentials from becoming inaccessible after the lifecycle dropped privileges.

matejvasek commented 2 months ago

btw there is already v4 of codecov/codecov-action that is failing

natalieparellano commented 2 months ago

Looks like the Codecov token is now required, this should be fixed in https://github.com/buildpacks/lifecycle/pull/1282 then we can merge this one

jabrown85 commented 2 months ago

You should be able to rebase now @natalieparellano