search

buildpacks / lifecycle

Reference implementation of the Cloud Native Buildpacks lifecycle
https://buildpacks.io
Apache License 2.0
186 stars 105 forks source link

Breaking usage of buildpacks betwen v0.19.6 and v0.20.0 #1388

Open remyleone opened 1 month ago

remyleone commented 1 month ago

Summary

When I try to upgrade the usage of buildpacks I got I have a problem at compile time that is not in my code.

github.com/buildpacks/lifecycle/buildpack
# github.com/buildpacks/lifecycle/buildpack
../../go/pkg/mod/github.com/buildpacks/lifecycle@v0.20.0/buildpack/dockerfile.go:77:46: not enough arguments in call to instructions.Parse
        have (*parser.Node)
        want (*parser.Node, *linter.Linter)

Reproduction

Steps

Checkout this repository: https://github.com/scaleway/scaleway-cli

Try to upgrade the dependency for github.com/buildpacks/lifecycle/buildpack

Current behavior
github.com/buildpacks/lifecycle/buildpack
# github.com/buildpacks/lifecycle/buildpack
../../go/pkg/mod/github.com/buildpacks/lifecycle@v0.20.0/buildpack/dockerfile.go:77:46: not enough arguments in call to instructions.Parse
        have (*parser.Node)
        want (*parser.Node, *linter.Linter)
Expected behavior

I expect my code to compile because it didn't change and this is labelled as a minor patch.

Context

lifecycle version
platform version(s)
anything else?
natalieparellano commented 1 month ago

Hi @remyleone - is it possible you also upgraded your buildkit version along with the lifecycle? I see this error when bumping to v0.14.x. I see v0.13.2 here but not sure if it's the right branch. Lifecycle v0.20.0 is still on v0.13.2.