search

buildpacks / lifecycle

Reference implementation of the Cloud Native Buildpacks lifecycle
https://buildpacks.io
Apache License 2.0
186 stars 105 forks source link

Extend Creator Acceptance Tests #468

Open ekcasey opened 3 years ago

ekcasey commented 3 years ago

Add acceptance tests for creator.

These can be minimal smoke tests assuming that much of the logic will be covered by the phase-specific acceptance tests.

natalieparellano commented 3 years ago

The tests should run on Linux and Windows. They should cover most command invocations (see Detector & Analyzer as examples) and should include a test of the exit code in case of error (see Detector as an example).

natalieparellano commented 3 years ago

Since we're shipping stack buildpacks with 0.12.0, https://github.com/buildpacks/lifecycle/issues/466 might be a better candidate for this milestone.

natalieparellano commented 3 years ago

These were introduced in #698 but are currently very only minimal.

sagnik3788 commented 8 months ago

@natalieparellano may i give it a try

natalieparellano commented 8 months ago

@sagnik3788 sure! We are happy to have your help :)

sagnik3788 commented 8 months ago

@natalieparellano Creator tests should run on both Linux and Windows however currently, Windows is not supported. Besides addressing Windows support are there any specific tests that we need to extend ?

natalieparellano commented 8 months ago

@sagnik3788 apologies for the slow reply here. At the moment I think it's OK if these tests don't run on Windows. I guess we intended to make the tests more "robust" but beyond that I can't think of any tests that we absolutely must add. It's possible that what we have already is good enough, and we can close this issue