search

buildpacks / pack-orb

A CircleCI Orb for using Cloud Native Buildpacks in CircleCI
https://circleci.com/orbs/registry/orb/buildpacks/pack
Apache License 2.0
12 stars 8 forks source link

Working directory is a required param without a default, but the command could provide a default #22

Closed genevieve closed 3 years ago

genevieve commented 3 years ago

In the orb examples, there is no working-directory provided: https://github.com/buildpacks/pack-orb/blob/e380792cfd5b0d58207a58307e7295b6083f19c5/orb.yml#L192-L195

However, there is no default for that parameter so it is required on usage:

# Error calling job: 'buildpacks/build'
# Missing required argument(s): working-directory
# 
# -------
# Warning: This configuration was auto-generated to show you the message above.
# Don't rerun this job. Rerunning will have no effect.
false

It appears that the actual command implementation does have a backup of "" for this value which could be moved to the default definition of the parameter: https://github.com/buildpacks/pack-orb/blob/e380792cfd5b0d58207a58307e7295b6083f19c5/orb.yml#L116