search

buildpacks / pack-orb

A CircleCI Orb for using Cloud Native Buildpacks in CircleCI
https://circleci.com/orbs/registry/orb/buildpacks/pack
Apache License 2.0
12 stars 8 forks source link

Fix update-version.yml, update pack in @orb.yml #37

Closed importhuman closed 3 years ago

importhuman commented 3 years ago

The earlier version failed recently, this should fix it, and I've also manually updated the pack version in the relevant file.

Signed-off-by: Ujjwal Goyal importujjwal@gmail.com

jromero commented 3 years ago

I might have merged this in too hastily. I'm wondering if we should add a manual dispatch so that we can trigger it manually.

importhuman commented 3 years ago

@jromero taking a cursory look at the link, it should be simple enough, but what would be the use case? To trigger a run in case the workflow fails and needs to be updated?

Edit: Considering that a similar workflow is there in the github-actions repo and wasn't merged before the latest pack release, it makes sense to add a manual trigger as well. I'll work on it, what do you think the input fields should be, if any?

jromero commented 3 years ago

@importhuman there are cases in which something unexpected occurs and the build fails. IE. GitHub runner is having temporary networking issues. In the most recent case here, I would have loved to be able to retrigger the action after your fix to the action itself.

As far as inputs go, I don't think we need one since it's pulling the latest data from GH releases.