search

buildpacks / pack-orb

A CircleCI Orb for using Cloud Native Buildpacks in CircleCI
https://circleci.com/orbs/registry/orb/buildpacks/pack
Apache License 2.0
12 stars 8 forks source link

Add `--retry` to curl usages #45

Closed edmorley closed 2 years ago

edmorley commented 2 years ago

Hi!

I recently encountered this transient CI failure whilst using the pack/install-pack command:

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:--  0:02:11 --:--:--     0
curl: (28) Failed to connect to github.com port 443: Connection timed out

gzip: stdin: unexpected end of file
tar: Child returned status 1
tar: Error is not recoverable: exiting now

Exited with code exit status 2

(https://app.circleci.com/pipelines/github/heroku/pack-images/1707/workflows/2e556988-a8b5-404e-990c-35591f1016bf/jobs/34140)

To improve CI reliability it may be worth adding --retry to the curl usages in this orb, and potentially also a suitable --connect-timeout. (The same changes should probably also be made to https://github.com/buildpacks/github-actions)

I'll open a PR.