Open dlion opened 11 months ago
We need to wait for platform 0.13 to work on this
We reviewed the Platform 0.13 scope yesterday during our WG meeting, I think we will unblock this issue soon
It should be possible to work on this one already - though there isn't a released lifecycle that supports it, we should be able to verify that the flag is passed all the way down from the command line invocation to the "lifecycle execution"
Adding a few notes here in case that makes it easier to pick up:
pack build
(example)Questions:
cc @jjbustamante
Thank you very much @natalieparellano, all those hints are great for new contributors.
Questions: Do we need to add warnings anywhere when insecure registry options are provided?
I will say Yes, using an insecure registry is probably something just for development and it is valuable to add some warnings
@prashantrewar what about this one? do you want to give it a try?
@prashantrewar what about this one? do you want to give it a try?
Sure, I will try.
Thank you so much @jjbustamante
/assign
Hey @jjbustamante and @natalieparellano I have a question related to image.NewFetcher
.
How should I pass the insecureRegistries
values to the client?
@natalieparellano, could you please describe me more on the [rebase] (https://github.com/buildpacks/pack/blob/8ed450d44de15cefe5875c22ae87293cc625e69d/pkg/client/rebase.go#L116) about what changes are you expecting?
hi @prashantrewar!
I think for the rebase we need the following:
pack rebase
command to get the insecure registry valuesHey, @jjbustamante and @natalieparellano I created a PR on this issue. Could you please take a look and suggest any changes if required?
Thank you for the help.
I'm opening this issue to track the work that needs to be done on pack to enable the support for insecure registries.
Sample Command
Dependencies
Once this PR is merged the work on this issue can be started
Main tracking issue: https://github.com/buildpacks/rfcs/issues/246