search

buildpacks / pack

CLI for building apps using Cloud Native Buildpacks
https://buildpacks.io
Apache License 2.0
2.47k stars 278 forks source link

Remove validation of deprecated `io.buildpacks.stack.id` #2104

Open matthewrobertson opened 3 months ago

matthewrobertson commented 3 months ago

Summary

Pack still has logic that validates the builder and run image have a matching value set for the io.buildpacks.stack.id here. This label is deprecated as of platform v0.12 so we should probably weaken this validation.

Reproduction

Run a pack build using a packeto builder and google run image:

pack build stack-validation \
  --builder paketobuildpacks/builder-jammy-base
  --run-image gcr.io/buildpacks
Current behavior

Build fails with an error message about mistmatched stack IDs

run-image stack "google.22" does not match builder stackID...

Expected behavior

The builder and run image are both derived from Ubuntu Jammy so we should allow the build proceed

Environment

Linux

pack info

All versions of pack impacted

docker info

N/A

natalieparellano commented 3 months ago

This might benefit from some synchronous discussion so I've added it as a "future topic" for one of our Working Groups

natalieparellano commented 3 months ago

Discussed in 3/28 Working Group: we think we can replace the error with a warning. The warning should probably note that stacks are deprecated so that folks who are not using stacks can simply ignore it.