Do not initialize `http.Client` during each request to a remote location

buildpacks / pack

CLI for building apps using Cloud Native Buildpacks

https://buildpacks.io

Apache License 2.0

2.56k stars 286 forks source link

Do not initialize `http.Client` during each request to a remote location #2151

Closed pbusko closed 4 months ago

pbusko commented 4 months ago

Summary

Instead of initialising the http.Client during every call to the downloader.Download, use the http.DefaultClient. Also custom client can be provided with the blob.WithClient option (for example with a custom RoundTripper for injecting credentials)

buildpacks / pack

Do not initialize `http.Client` during each request to a remote location #2151

Summary

Output

Before

After

Documentation

Related