search

buildpacks / pack

CLI for building apps using Cloud Native Buildpacks
https://buildpacks.io
Apache License 2.0
2.47k stars 279 forks source link

When validating buildpack.toml, don't warn for keys that are actually defined #2161

Closed natalieparellano closed 1 month ago

natalieparellano commented 1 month ago

Summary

Fixes the overly aggressive validation that was added in https://github.com/buildpacks/pack/pull/2123

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 70.54%. Comparing base (302963e) to head (47ae7a3).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/buildpacks/pack/pull/2161/graphs/tree.svg?width=650&height=150&src=pr&token=98nLRtpSGh&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=buildpacks)](https://app.codecov.io/gh/buildpacks/pack/pull/2161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=buildpacks) ```diff @@ Coverage Diff @@ ## main #2161 +/- ## ========================================== + Coverage 70.53% 70.54% +0.01% ========================================== Files 251 251 Lines 17980 17985 +5 ========================================== + Hits 12680 12685 +5 Misses 4482 4482 Partials 818 818 ``` | [Flag](https://app.codecov.io/gh/buildpacks/pack/pull/2161/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=buildpacks) | Coverage Δ | | |---|---|---| | [os_linux](https://app.codecov.io/gh/buildpacks/pack/pull/2161/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=buildpacks) | `69.66% <87.50%> (+0.02%)` | :arrow_up: | | [os_macos](https://app.codecov.io/gh/buildpacks/pack/pull/2161/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=buildpacks) | `65.99% <87.50%> (+0.01%)` | :arrow_up: | | [os_windows](https://app.codecov.io/gh/buildpacks/pack/pull/2161/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=buildpacks) | `70.04% <87.50%> (+0.01%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/buildpacks/pack/pull/2161/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=buildpacks) | `70.54% <87.50%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=buildpacks#carryforward-flags-in-the-pull-request-comment) to find out more.