buildpacks / pack

CLI for building apps using Cloud Native Buildpacks
https://buildpacks.io
Apache License 2.0
2.47k stars 279 forks source link

Publishing wrong architecture for `macos` intel binaries #2167

Closed jjbustamante closed 1 month ago

jjbustamante commented 1 month ago

Description

Once we released pack 0.34.0-rc1 I noticed the binaries for macos intel machine is actually a arm64 binary, the reason is because the latest macos runner from github is now macos14 and than runner is based on arm64 architecture. Github docs

The problem was that we were expecting the darwin binary built during CI to be based on amd64 and since the runner was updated this not true. We ended up shipping the same binary (arm64) twice

Proposed solution

The easiest way to fix it, is to build by default the arm64 binary during CI, and build the amd64 when a release is done. The problem with this solution is that sometimes we ask people from the community to download binaries from a PR and in this case, if they running macos on intel, we will not have binaries available.

Additional context

natalieparellano commented 1 month ago

Could we maybe cut an rc2 to allow more folks to try out the binary?