search

buildpacks / pack

CLI for building apps using Cloud Native Buildpacks
https://buildpacks.io
Apache License 2.0
2.47k stars 279 forks source link

Don't create an ephemeral builder if it isn't truly needed #2196

Open natalieparellano opened 2 days ago

natalieparellano commented 2 days ago

Fixes https://github.com/buildpacks/pack/issues/2195

Summary

Output

Before

After

Documentation

Related

Resolves #___

codecov[bot] commented 2 days ago

Codecov Report

Attention: Patch coverage is 68.75000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 70.16%. Comparing base (ce8db3c) to head (423f596).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/buildpacks/pack/pull/2196/graphs/tree.svg?width=650&height=150&src=pr&token=98nLRtpSGh&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=buildpacks)](https://app.codecov.io/gh/buildpacks/pack/pull/2196?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=buildpacks) ```diff @@ Coverage Diff @@ ## main #2196 +/- ## ========================================== - Coverage 70.17% 70.16% -0.01% ========================================== Files 253 253 Lines 18452 18495 +43 ========================================== + Hits 12947 12975 +28 - Misses 4659 4671 +12 - Partials 846 849 +3 ``` | [Flag](https://app.codecov.io/gh/buildpacks/pack/pull/2196/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=buildpacks) | Coverage Δ | | |---|---|---| | [os_linux](https://app.codecov.io/gh/buildpacks/pack/pull/2196/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=buildpacks) | `69.30% <68.75%> (-<0.01%)` | :arrow_down: | | [os_macos-arm64](https://app.codecov.io/gh/buildpacks/pack/pull/2196/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=buildpacks) | `65.60% <68.75%> (-0.01%)` | :arrow_down: | | [os_windows](https://app.codecov.io/gh/buildpacks/pack/pull/2196/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=buildpacks) | `69.68% <68.75%> (-0.01%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/buildpacks/pack/pull/2196/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=buildpacks) | `70.16% <68.75%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=buildpacks#carryforward-flags-in-the-pull-request-comment) to find out more.