natalieparellano
commented
1 week ago cc @ForestEckhardt as Paketo maintainer for thoughts
Open edmorley opened 1 week ago
natalieparellano
commented
1 week ago cc @ForestEckhardt as Paketo maintainer for thoughts
Description
Currently the Pack CLI's known builders list contains the following suggested Paketo builders: https://github.com/buildpacks/pack/blob/ce8db3c5d11b8e040fd565632668a697e53e4f87/internal/builder/known_builder.go#L40-L67
The descriptions for the builders defined in this repo (which are used when offline and Pack CLI can't pull from the registry) currently don't match the descriptions set on the builders themselves: https://github.com/paketo-buildpacks/builder-jammy-base/blob/a967f70684506e873bc7c8b23a74f46d51d3c526/builder.toml#L1 https://github.com/paketo-buildpacks/builder-jammy-full/blob/406b1cd36df58012e4700050f42e718bda76d572/builder.toml#L1 https://github.com/paketo-buildpacks/builder-jammy-tiny/blob/bf9411eb6aa3ecf208976bf3154d90f536a4bd74/builder.toml#L1
Also, I'm a bit confused why
paketobuildpacks/builder-jammy-buildpackless-staticis a Pack suggested builder, when that builder isn't listed on the Paketro builders page? https://paketo.io/docs/reference/builders-reference/Lastly, I wonder whether having 4 suggested builders might be slightly too many, given Heroku and Google only have one suggested builder each? I think it does make sense to include the full vs base vs tiny builders, but perhaps the "buildpackless" builder variant shouldn't be a suggested builder? (If only because it's not really suitable for beginners, given it won't work without also specifying external buildpacks.)
Proposed solution
builder.tomlmetadatapaketobuildpacks/builder-jammy-buildpackless-staticto being only a trusted builder and not also a suggested builder. (Or if that builder is deprecated, given it's not listed on https://paketo.io/docs/reference/builders-reference/ , then perhaps remove it from known-builders entirely?)