search

buildpacks / packs

Buildpack cloud builders for the classic v2a (Heroku-style) and v2b (CF-style) buildpacks
https://buildpacks.io
Apache License 2.0
15 stars 8 forks source link

Small fixes for heroku images #2

Closed sclevine closed 6 years ago

sclevine commented 6 years ago

@jkutner Let me know what you think of these changes. For the most part, I removed dead code. I also changed the default input slug from /tmp/sluget to /tmp/droplet to match the lifecycle default, but I'm happy to change it back if you'd prefer.

I think the lack of versions in heroku.json will make it difficult to rebuild with the latest Heroku buildpacks. I didn't fix that, but you may want to figure out a way to version the URLs in that file.

Also, I'm happy to add you and Terence as collaborators to this repo if you'd like.

jkutner commented 6 years ago

@sclevine thanks, these changes look good. Why will the heroku.json w/o versions make it difficult to rebuild? We can easily add versioned URLs, but I concerned about requiring a Git commit to update them. Eventually I imagine we want to roll out new packs images as new buildpacks are released.

WRT collaborators it's up to you. I will probably still ask for your review and make PRs for each change until I'm a little more comfortable with the direction.

sclevine commented 6 years ago

Awesome! I'll merge this tonight.

With cflinuxfs2.json, running /cf/bin/update followed by /cf/bin/build will always give you the latest buildpack versions, because the cflinuxfs2.json file changes and expires the cached image layer with the buildpacks in it.

I'm not sure I like a git commit for each version update either, but it does serve as a source of truth for what buildpack versions are available in the image.

Eventually (ideally soon), I'd like a cron job on travis to handle updating the images. Maybe that job could add metadata to the image with the versions instead of committing them back into the repo?