Update Heroku images to use Heroku's Cytokine

buildpacks / packs

Buildpack cloud builders for the classic v2a (Heroku-style) and v2b (CF-style) buildpacks

https://buildpacks.io

Apache License 2.0

15 stars 8 forks source link

Update Heroku images to use Heroku's Cytokine #6

Closed jkutner closed 6 years ago

jkutner commented 6 years ago

This change updates the following:

The build image now uses Cytokine to run buildpacks
The run image now uses the release.yml (which is output from cytokine) to determine process types.

/cc @hone

sclevine commented 6 years ago

Merged, fixed some gofmt/govet issues, and standardized the exit codes. I didn't change the error checking to use the shared logic or change any of the flags. Let me know if you'd like me to make those changes, or to refactor the heroku Dockerfiles to match the multi-stage CF ones.

Also, let me know if I should publish the new images, and if you're okay with CI doing that automatically now.

jkutner commented 6 years ago

@sclevine definitely ok with CI doing that. If you're going to do it manually, we need #7 merged first.