RFC for exporting images in parallel

buildpacks / rfcs

RFCs for Cloud Native Buildpacks

Apache License 2.0

56 stars 71 forks source link

RFC for exporting images in parallel #291

Closed ESWZY closed 9 months ago

ESWZY commented 10 months ago

We already have some discussion here: lifecycle#1167.

Readable

buildpack-bot commented 10 months ago

Maintainers,

As you review this RFC please queue up issues to be created using the following commands:

/queue-issue <repo> "<title>" [labels]...
/unqueue-issue <uid>

Issues

(none)

jjbustamante commented 10 months ago

Hi @ESWZY!

Thank you so much for working on this proposal and the RFC it is really awesome!

My suggestions:

Add to the what is this section the propose flag to the exporter that will enable the feature. Usually we just add a table, similar to the one in the spec, with the new flag we want to incorporate.
Once you have the flag, in the how it works section, you can just add a few examples of invocations of the exporter with the new flag and you can explain the expected outcome and behavior.

The new flags, at the end, will require a new API spec, so you can also put them under the Spec. Changes section, but that is something can be done later once you get consensus from the community around the feature.

ESWZY commented 10 months ago

Hi @ESWZY!

Thank you so much for working on this proposal and the RFC it is really awesome!

My suggestions:

Add to the what is this section the propose flag to the exporter that will enable the feature. Usually we just add a table, similar to the one in the spec, with the new flag we want to incorporate.

Once you have the flag, in the how it works section, you can just add a few examples of invocations of the exporter with the new flag and you can explain the expected outcome and behavior.

The new flags, at the end, will require a new API spec, so you can also put them under the Spec. Changes section, but that is something can be done later once you get consensus from the community around the feature.

Thanks for your suggestion!

I added a proposal flag to this PRC and made a preliminary attempt in lifecycle#1167.

jjbustamante commented 10 months ago

Awesome work @ESWZY! I really like this RFC

natalieparellano commented 9 months ago

Moved to voting, as this is a sub-team RFC and has approvals from both implementation maintainers I think we can merge it early cc @jabrown85