buildpacks / rfcs

RFCs for Cloud Native Buildpacks
Apache License 2.0
56 stars 71 forks source link

RFC for build environment variables #293

Open kappratiksha opened 1 year ago

kappratiksha commented 1 year ago

RFC for adding a new flag for build environment variables

buildpack-bot commented 1 year ago

Maintainers,

As you review this RFC please queue up issues to be created using the following commands:

/queue-issue <repo> "<title>" [labels]...
/unqueue-issue <uid>

Issues

(none)

jjbustamante commented 1 year ago

Hi @kappratiksha!

Thanks for contributing with this RFC!

My initial though is the suggested change is moving the creator to the platform field. As you correctly pointed out, pack offers a more user friendly way to set environment variables, but that is actually the kind of functionalities we are expecting from a platform implementation. In this case, the proposal seems to try to make the creator to look like a platform.

In the last working group meeting we discussed the problem with certain platforms, like google, having problems with mounting volumes with files to configure the lifecycle execution and exposing flags could be a better approach. l I think this RFC goes into that direction. With that in mind, I will suggest:

Also, based on the spec running the creator should be equivalent to running the phases individually, this means, the behavior added to the creator with the new --env flag should also be achievable with other phases, so I think the RFC should also detail how are we planning to do it.