search

buildpacks / rfcs

RFCs for Cloud Native Buildpacks
Apache License 2.0
56 stars 71 forks source link

Add RFC for extension layers #301

Closed c0d1ngm0nk3y closed 7 months ago

c0d1ngm0nk3y commented 9 months ago

readable

buildpack-bot commented 9 months ago

Maintainers,

As you review this RFC please queue up issues to be created using the following commands:

/queue-issue <repo> "<title>" [labels]...
/unqueue-issue <uid>

Issues

(none)

loewenstein commented 9 months ago

@natalieparellano how do we manage to get feedback? We don't seem to be able to request a review.

pbusko commented 8 months ago

@jabrown85 @natalieparellano the RFC has been updated with the proposed changes.

loewenstein commented 8 months ago

I wonder what the state of this is? @natalieparellano is there anything missing from your point of view? @pbusko are we on top of all provided review feedback?

natalieparellano commented 8 months ago

I wonder what the state of this is? @natalieparellano is there anything missing from your point of view? @pbusko are we on top of all provided review feedback?

I left two new comments (here and here) but otherwise I think this is ready. If we don't evolve it any further after this week we can put it up for votes.

pbusko commented 8 months ago

I left two new comments (here and here) but otherwise I think this is ready. If we don't evolve it any further after this week we can put it up for votes.

The comments have been addressed

loewenstein commented 7 months ago

I wonder what the state of this is? @natalieparellano is there anything missing from your point of view? @pbusko are we on top of all provided review feedback?

I left two new comments (here and here) but otherwise I think this is ready. If we don't evolve it any further after this week we can put it up for votes.

@natalieparellano are you putting up for vote?

loewenstein commented 7 months ago

@jabrown85 could you help bringing this to a vote and getting it merged. That would be great. I hesitate to immediately start working on spec and implementation pull requests - inviting people to vote might lead to more review comments that lead to changes, but I would really like to see https://github.com/buildpacks/spec/issues/378 closed and 0.13 released as soon as possible.

pbusko commented 7 months ago

@natalieparellano please let us know if there's something still unclear/blocking the RFC from being merged

loewenstein commented 7 months ago

@natalieparellano @jabrown85 anything blocking a vote, merge and implementation?

natalieparellano commented 7 months ago

@jabrown85 could you give this one a read?

natalieparellano commented 7 months ago

Let's merge this one, it was moved into voting exactly one week ago...