Closed edmorley closed 4 months ago
Maintainers,
As you review this RFC please queue up issues to be created using the following commands:
/queue-issue <repo> "<title>" [labels]...
/unqueue-issue <uid>
(none)
@natalieparellano Sure - added now :-)
Oh I also found one more change that was made when the spec was updated, that I've backported now:
versions
field within [[targets.distros]]
was renamed to version
(along with its type changing from an array to a string).This backports those changes to the RFC to try and prevent user confusion if they use the RFC as a means of learning about targets when implementing.
To give some more context here - one of the reasons I look at the RFCs when implementing, is that they are quite prominently linked from the spec GitHub release entries: https://github.com/buildpacks/spec/releases
(Me using the GitHub rebase button broke the GPG verification status of the commits, so I've squashed and manually pushed instead)
It's spreading! 😆 https://github.com/buildpacks/rfcs/pull/295#discussion_r1559614121
Please can I have review/merge? :-)
A few changes were made to what was in RFC96 when it came to update the spec: https://github.com/buildpacks/spec/pull/365
This backports those changes to the RFC to try and prevent user confusion if they use the RFC as a means of learning about targets when implementing.
Specifically:
io.buildpacks.distribution.*
Docker labels were renamed toio.buildpacks.base.distro.*
.io.buildpacks.id
Docker label was renamed toio.buildpacks.base.id
.buildpack.toml
table[[targets.distributions]]
was renamed to[[targets.distros]]
and theversions
field within it renamed toversion
(along with its type changing from an array to a string).See: https://github.com/buildpacks/spec/blob/platform/0.13/platform.md#target-data