buildpacks / rfcs

RFCs for Cloud Native Buildpacks
Apache License 2.0
56 stars 71 forks source link

Update RFC 0096 (stacks removal) to match what landed in the spec #310

Closed edmorley closed 4 months ago

edmorley commented 6 months ago

A few changes were made to what was in RFC96 when it came to update the spec: https://github.com/buildpacks/spec/pull/365

This backports those changes to the RFC to try and prevent user confusion if they use the RFC as a means of learning about targets when implementing.

Specifically:

See: https://github.com/buildpacks/spec/blob/platform/0.13/platform.md#target-data

buildpack-bot commented 6 months ago

Maintainers,

As you review this RFC please queue up issues to be created using the following commands:

/queue-issue <repo> "<title>" [labels]...
/unqueue-issue <uid>

Issues

(none)

edmorley commented 6 months ago

@natalieparellano Sure - added now :-)

edmorley commented 6 months ago

Oh I also found one more change that was made when the spec was updated, that I've backported now:

(xref https://github.com/buildpacks/spec/issues/401)

edmorley commented 6 months ago

This backports those changes to the RFC to try and prevent user confusion if they use the RFC as a means of learning about targets when implementing.

To give some more context here - one of the reasons I look at the RFCs when implementing, is that they are quite prominently linked from the spec GitHub release entries: https://github.com/buildpacks/spec/releases

edmorley commented 5 months ago

(Me using the GitHub rebase button broke the GPG verification status of the commits, so I've squashed and manually pushed instead)

edmorley commented 5 months ago

It's spreading! 😆 https://github.com/buildpacks/rfcs/pull/295#discussion_r1559614121

edmorley commented 4 months ago

Please can I have review/merge? :-)