buildpacks / rfcs

RFCs for Cloud Native Buildpacks
Apache License 2.0
56 stars 71 forks source link

Use correct `[[targets.distros]]` schema in RFC 0128 #312

Closed edmorley closed 4 months ago

edmorley commented 5 months ago

Updates RFC 0128 to use the correct [[targets.distros]] schema as defined already in the spec: https://github.com/buildpacks/spec/blob/main/buildpack.md#buildpacktoml-toml

I've not added an ## Amended section, since:

  1. The RFC has only just merged (this is effectively a review comment that missed the merge by a day)
  2. The parts of the RFC being fixed are existing concepts already in the spec, rather than design decisions relating to the purpose of the RFC itself.

Fixes https://github.com/buildpacks/rfcs/pull/295#discussion_r1559614121.

buildpack-bot commented 5 months ago

Maintainers,

As you review this RFC please queue up issues to be created using the following commands:

/queue-issue <repo> "<title>" [labels]...
/unqueue-issue <uid>

Issues

(none)

edmorley commented 5 months ago

@jjbustamante Could I have review? :-)

jjbustamante commented 5 months ago

Just to be consistent with the process, I think we should add the Amend section at the bottom

<!--
## Amended
### Meta
[meta-1]: #meta-1
- Name: (fill in the amendment name: Variable Rename)
- Start Date: (fill in today's date: YYYY-MM-DD)
- Author(s): (Github usernames)
- Amendment Pull Request: (leave blank)

### Summary

A brief description of the changes.

### Motivation

Why was this amendment necessary?
--->
edmorley commented 5 months ago

Just to be consistent with the process, I think we should add the Amend section at the bottom

I explained why I didn't add this section in the PR description. I still think we shouldn't add one.

edmorley commented 5 months ago

Ultimately this is a typo fix to something unrelated to the RFC, not a change in the actual intent of the RFC.

edmorley commented 4 months ago

Please can someone merge this?

edmorley commented 4 months ago

Thank you :-)